Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aws-sdk-pinning and revert to arrow 12.0.1 #14319

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Remove aws-sdk-pinning and revert to arrow 12.0.1 #14319

merged 3 commits into from
Oct 24, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 23, 2023

Description

The aws-sdk-pinning is proving to be far too problematic to maintain. It causes conflicts in many environments due to its common usage across many other packages in the conda-forge ecosystem that have since updated their pinning to require newer versions than the 1.10.* that we've pinned to. This reversion will unblock most of RAPIDS CI. We will search for alternative fixes to the dask-cuda/distributed issues that we're observing (in particular, resolution of the underlying issues apache/arrow#38364 and aws/aws-sdk-cpp#2681).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 23, 2023
@vyasr vyasr self-assigned this Oct 23, 2023
@vyasr vyasr requested review from a team as code owners October 23, 2023 21:50
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue conda labels Oct 23, 2023
bdice
bdice reviewed Oct 23, 2023
View reviewed changes
dependencies.yaml Outdated Show resolved Hide resolved
conda/recipes/cudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libcudf/conda_build_config.yaml Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from bdice October 23, 2023 22:43
pentschev
pentschev approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change, but I'd prefer if we merge #14321 in first, that might help us narrow the scope of a potential fallout due to this.

python/cudf/pyproject.toml Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Oct 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit b390bca into rapidsai:branch-23.12 Oct 24, 2023
54 checks passed
@vyasr vyasr deleted the fix/aws_arrow_pinning branch October 24, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@wence- wence- wence- approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @wence- @raydouglass @bdice @pentschev