Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test is_valid before reading column data #14318

Merged
merged 1 commit into from
Oct 23, 2023
Merged

test is_valid before reading column data #14318

merged 1 commit into from
Oct 23, 2023

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Oct 23, 2023

Description

Fixes #14310.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@etseidl etseidl requested a review from a team as a code owner October 23, 2023 21:14
@etseidl etseidl requested review from bdice and nvdbaranec October 23, 2023 21:14
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 23, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 23, 2023
@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 23, 2023
@davidwendt
Copy link
Contributor

/ok to test

davidwendt
davidwendt approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified locally this fixes the memcheck error reported in #14310

@davidwendt
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 630982a into rapidsai:branch-23.12 Oct 23, 2023
54 checks passed
@etseidl etseidl deleted the fix_invalid_read branch October 24, 2023 00:05
@GregoryKimball
Copy link
Contributor

Thank you @etseidl for jumping on this and thank you @davidwendt for confirming the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@vuule vuule vuule approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] memcheck error reported in gpuEncodeDeltaBinaryPages in ParquetWriterDeltaTest/0.SupportedDeltaTestTypes
4 participants
@etseidl @davidwendt @GregoryKimball @vuule