Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gtest validity setting for TextTokenizeTest.Vocabulary #14312

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fix gtest validity setting for TextTokenizeTest.Vocabulary #14312

merged 2 commits into from
Oct 26, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Fixes the TextTokenizeTest.Vocabulary which incorrectly created a non-empty null row for input and the expected output.
This was found while working on optimizing the nvtext::tokenize_with_vocabulary API.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Oct 23, 2023
@davidwendt davidwendt self-assigned this Oct 23, 2023
@davidwendt davidwendt requested a review from a team as a code owner October 23, 2023 15:53
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a2abdb1 into rapidsai:branch-23.12 Oct 26, 2023
54 checks passed
@davidwendt davidwendt deleted the fix-vocab-test branch October 26, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@PointKernel PointKernel Awaiting requested review from PointKernel PointKernel is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @karthikeyann