-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes stack context for json lines format that recovers from invalid JSON lines #14309
Merged
rapids-bot
merged 7 commits into
rapidsai:branch-23.12
from
elstehle:fix/json-lines-recovering-stack-ctx
Oct 31, 2023
Merged
Fixes stack context for json lines format that recovers from invalid JSON lines #14309
rapids-bot
merged 7 commits into
rapidsai:branch-23.12
from
elstehle:fix/json-lines-recovering-stack-ctx
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elstehle
added
bug
Something isn't working
3 - Ready for Review
Ready for review by team
cuIO
cuIO issue
non-breaking
Non-breaking change
labels
Oct 22, 2023
vuule
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just one question to confirm my understanding
…nes-recovering-stack-ctx
elstehle
changed the title
Fixes stack context for json lines format that recovers from invalid JSON lines
Fixes stack context for json lines format that recovers from invalid JSON lines
Oct 26, 2023
…nes-recovering-stack-ctx
…nes-recovering-stack-ctx
…nes-recovering-stack-ctx
karthikeyann
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
cuIO
cuIO issue
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #14282.
For the JSON lines format that recovers after an invalid JSON line, we've had two issues when we were generating the stack context that is used downstream in the full JSON pushdown transducer.
For that format, we need to make sure that we "reset" the stack context after each JSON line. That is,
{"this opening brace is never closed":123\n{"<=this brace should be on the empty stack":...}
{"no matching end-quote on this line\n{"<=this quote is the beginning of a field name, not the end of the previous line's field name"
This fixes above requirements as follows:
E.g. (
{,n,{
,},n,{
,{,n,}
,},n,}
all fail the associativity test). This was replaced with aScanByKey
that would start with a "fresh" stack level with each new key segment.OOS
(outside-of-string
) state after every newline. This behaviour requires that every newline character is treated as a delimiter of a JSON line. This was confirmed by Spark Rapids, who is the targeted user for the recovery option to be the case.Checklist