-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stream parameter to Set Operations (Public List APIs) #14305
Add stream parameter to Set Operations (Public List APIs) #14305
Conversation
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Those are not quite "list" operations. Indeed, they are set operations (set is part of list, but saying "list" means something else). |
Thanks @ttnghia. I have updated the PR title and description. |
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
/ok to test |
The test for
|
To reproduce locally, add the |
Just to update the benchmark code to add |
Thanks @davidwendt @ttnghia, I'll do that! |
Signed-off-by: Suraj Aralihalli <[email protected]>
/ok to test |
/merge |
This PR marks the conclusion of the List API series. The PR introduces the stream parameter to the Set operations (Public List Comparison and Intersection APIs).
Comparison and Intersection (
set_operations.hpp
)Reference 13744
Checklist