Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose stream parameter to get_json_object API #14297

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Expose stream parameter to get_json_object API #14297

merged 5 commits into from
Nov 1, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Add stream parameter to public APIs cudf::get_json_object()
Also removed the API from the strings namespace since it does not fit with the other strings library functions.
This resulted in updating the source file locations as well.

Reference #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 18, 2023
@davidwendt davidwendt self-assigned this Oct 18, 2023
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue Java Affects Java cuDF API. labels Oct 18, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 23, 2023
@davidwendt davidwendt marked this pull request as ready for review October 24, 2023 21:59
@davidwendt davidwendt requested review from a team as code owners October 24, 2023 21:59
karthikeyann
karthikeyann approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels Oct 30, 2023
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 56fe5db into rapidsai:branch-23.12 Nov 1, 2023
54 checks passed
@davidwendt davidwendt deleted the stream-json-get-object branch November 1, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwendt @bdice @karthikeyann @ttnghia @galipremsagar