-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing thread index overflow issue #14290
Merged
rapids-bot
merged 4 commits into
rapidsai:branch-23.12
from
hyperbolic2346:mwilson/thread_overflow
Oct 24, 2023
Merged
fixing thread index overflow issue #14290
rapids-bot
merged 4 commits into
rapidsai:branch-23.12
from
hyperbolic2346:mwilson/thread_overflow
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Wilson <[email protected]>
hyperbolic2346
added
bug
Something isn't working
3 - Ready for Review
Ready for review by team
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
labels
Oct 16, 2023
davidwendt
approved these changes
Oct 16, 2023
/ok to test |
ttnghia
approved these changes
Oct 16, 2023
/ok to test |
1 similar comment
/ok to test |
/ok to test |
2 similar comments
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ran across this issue during the review of NVIDIA/spark-rapids-jni#1502 and since the code was modeled after this code, I am pushing the fix here as well.
Checklist