Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versioning strategy #14285

Merged
merged 19 commits into from
Oct 31, 2023
Merged

Update versioning strategy #14285

merged 19 commits into from
Oct 31, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 13, 2023

Description

See rapidsai/rmm#1347

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 13, 2023
@vyasr vyasr self-assigned this Oct 13, 2023
@vyasr vyasr requested review from a team as code owners October 13, 2023 21:48
@github-actions github-actions bot added Python Affects Python cuDF API. conda labels Oct 13, 2023
@vyasr vyasr added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 13, 2023
wence-
wence- approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor polishing, looks good to me.

ci/release/update-version.sh Outdated Show resolved Hide resolved
python/cudf/cudf/_version.py Outdated Show resolved Hide resolved
@vyasr vyasr removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 27, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Oct 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 7358ecd into rapidsai:branch-23.12 Oct 31, 2023
54 checks passed
@vyasr vyasr deleted the feat/nightly_versions branch October 31, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@wence- wence- wence- approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @wence- @ajschmidt8