Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move and rename byte-pair-encoding source files #14284

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Move and rename byte-pair-encoding source files #14284

merged 9 commits into from
Oct 26, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Oct 13, 2023 •
edited
Loading

Description

Moves and renames the byte-pair-encoding source files. The source files are moved from the text/subword to text/bpe and the filenames have remove the tokenize since these functions only do encoding.
No functions names have been changed. The nvtext::load_merge_pairs_file API has been deprecated. Callers must load the pairs into a strings column (using the CSV or text readers in cuio) and call the new nvtext::load_merge_pairs API instead.

Follow on PRs will address function and performance issues.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 13, 2023
@davidwendt davidwendt self-assigned this Oct 13, 2023
@github-actions github-actions bot added the CMake CMake build issue label Oct 13, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 23, 2023
@davidwendt davidwendt marked this pull request as ready for review October 23, 2023 14:04
@davidwendt davidwendt requested review from a team as code owners October 23, 2023 14:04
bdice
bdice approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving aside from the pointer issue mentioned above.

cpp/include/nvtext/byte_pair_encoding.hpp Outdated Show resolved Hide resolved
@davidwendt davidwendt requested a review from ttnghia October 25, 2023 21:48
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d8f0790 into rapidsai:branch-23.12 Oct 26, 2023
54 checks passed
@davidwendt davidwendt deleted the bpe-move-files branch October 26, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @bdice @karthikeyann @ttnghia