Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rapids-cmake functions to non-deprecated signatures #14265

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Update rapids-cmake functions to non-deprecated signatures #14265

merged 3 commits into from
Oct 16, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Update to use non deprecated signatures for rapids_export functions

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 10, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner October 10, 2023 16:08
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Oct 10, 2023
harrism
harrism reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question. Otherwise looks good.

cpp/cmake/thirdparty/get_kvikio.cmake Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Oct 16, 2023

/merge

@rapids-bot rapids-bot bot merged commit 655f3a4 into rapidsai:branch-23.12 Oct 16, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism left review comments

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @bdice @harrism