-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize chunked reading code in the parquet reader to reader_impl_chunking.cu #14262
Centralize chunked reading code in the parquet reader to reader_impl_chunking.cu #14262
Conversation
… been changed to ::parquet::detail, ::parquet::gpu has been renamed to ::parquet::detail, and several detail-style files which were just using ::parquet have been moved into parquet::detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, assuming this is mostly code shuffle. Hard to compare when the code is moved between files.
Yes. Most of it is just the big blob from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving CMake changes
/merge |
As a precursor to further chunked reader work, this PR centralizes chunk-related code (mostly from the
reader::impl
class) intoreader_impl_chunking.cu
andreader_impl_chunking.hpp
. Also cleans up some variable naming and locations inreader::impl
and thefile_intermediate_data
andpass_intermediate_data classes
.