Handle empty string correctly in Parquet statistics #14257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karthikeyann could you please check the changes to the predicate pushdown to make sure that's correct? |
vuule
approved these changes
Oct 6, 2023
Comment on lines
+772
to
+780
| using optional_binary = parquet_field_optional<std::vector<uint8_t>, parquet_field_binary>; | ||
| using optional_int64 = parquet_field_optional<int64_t, parquet_field_int64>; | ||
|
|
||
| auto op = std::make_tuple(optional_binary(1, s->max), | ||
| optional_binary(2, s->min), | ||
| optional_int64(3, s->null_count), | ||
| optional_int64(4, s->distinct_count), | ||
| optional_binary(5, s->max_value), | ||
| optional_binary(6, s->min_value)); |
There was a problem hiding this comment.
Beautiful, the investment into parquet_field_optional is paying off!
Co-authored-by: Vukasin Milovanovic <[email protected]>
ttnghia
approved these changes
Oct 9, 2023
|
/ok to test |
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An empty string should be a valid minimum value for a string column, but the current parquet writer considers an empty string to have no value when writing the column chunk statistics. This PR changes all fields in the Statistics struct to be
thrust::optionalto help distinguish between a valid empty string and no value.Checklist