Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose stream parameter in public strings convert APIs #14255

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Add stream parameter to public APIs:

  • cudf::strings::to_booleans()
  • cudf::strings::from_booleans()
  • cudf::strings::to_timestamps()
  • cudf::strings::from_timestamps()
  • cudf::strings::is_timestamp()
  • cudf::strings::to_durations()
  • cudf::strings::from_durations()
  • cudf::strings::to_fixed_point()
  • cudf::strings::from_fixed_point()
  • cudf::strings::to_floats()
  • cudf::strings::from_floats()
  • cudf::strings::is_float()
  • cudf::strings::to_integers()
  • cudf::strings::from_integers()
  • cudf::strings::is_integer()
  • cudf::strings::hex_to_integers()
  • cudf::strings::integers_to_hex()
  • cudf::strings::is_hex()
  • cudf::strings::ipv4_to_integers()
  • cudf::strings::integers_to_ipv4()
  • cudf::strings::is_ipv4()
  • cudf::strings::url_encode()
  • cudf::strings::url_decode()
  • cudf::strings::format_list_column()

Also cleaned up some of the doxygen comments and removed some default parameters.

Reference #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 5, 2023
@davidwendt davidwendt self-assigned this Oct 5, 2023
@github-actions github-actions bot added the CMake CMake build issue label Oct 5, 2023
@github-actions github-actions bot added the Java Affects Java cuDF API. label Oct 5, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 6, 2023
@davidwendt davidwendt marked this pull request as ready for review October 12, 2023 13:44
@davidwendt davidwendt requested review from a team as code owners October 12, 2023 13:44
@davidwendt davidwendt requested review from mythrocks and vuule October 12, 2023 13:44
@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels Oct 12, 2023
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably there will be a lot more changes needed to change strings, integers, etc. into input name in the internal APIs.

@davidwendt
Copy link
Contributor Author

Probably there will be a lot more changes needed to change strings, integers, etc. into input name in the internal APIs.

The intention was to change strings to input because strings is part of the namespace name and sometimes produces confusing compile errors. We don't have the same issue with other types like booleans and integers so I'd like to leave those unchanged.

Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A couple of minor questions.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d590e0b into rapidsai:branch-23.12 Oct 16, 2023
57 checks passed
@davidwendt davidwendt deleted the stream-strings-convert branch October 16, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants