-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose stream parameter in public strings convert APIs #14255
Expose stream parameter in public strings convert APIs #14255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably there will be a lot more changes needed to change strings
, integers
, etc. into input
name in the internal APIs.
The intention was to change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A couple of minor questions.
/merge |
Description
Add stream parameter to public APIs:
cudf::strings::to_booleans()
cudf::strings::from_booleans()
cudf::strings::to_timestamps()
cudf::strings::from_timestamps()
cudf::strings::is_timestamp()
cudf::strings::to_durations()
cudf::strings::from_durations()
cudf::strings::to_fixed_point()
cudf::strings::from_fixed_point()
cudf::strings::to_floats()
cudf::strings::from_floats()
cudf::strings::is_float()
cudf::strings::to_integers()
cudf::strings::from_integers()
cudf::strings::is_integer()
cudf::strings::hex_to_integers()
cudf::strings::integers_to_hex()
cudf::strings::is_hex()
cudf::strings::ipv4_to_integers()
cudf::strings::integers_to_ipv4()
cudf::strings::is_ipv4()
cudf::strings::url_encode()
cudf::strings::url_decode()
cudf::strings::format_list_column()
Also cleaned up some of the doxygen comments and removed some default parameters.
Reference #13744
Checklist