-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in java bindings for DataSource #14254
Conversation
Signed-off-by: Robert (Bobby) Evans <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
@jlowe please take another look |
@davidwendt @vyasr could you please take a quick look at the C++ fix I had to put in to allow parquet/orc reads with a custom data source. |
Nice! |
I did most of it to try and see if it could help with some memory management pain points. This is one of the few places where we hold onto host memory while allocating GPU memory. It didn't work out exactly how we wanted, but the plan is to try and avoid an extra copy when stitching parts of ORC and parquet together into a final buffer we send to CUDF. It might get expanded to other things in the future. |
@vuule could you review the change I had to make to cpp/src/io/utilities/datasource.cpp? It is a C++ change to CUDF do I need a reviewer for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving libcudf C++ change.
/merge |
Description
This PR adds DataSource Java bindings. It also fixes a small bug in CUDF that made it so the bindings would not work for anything but CSV.
Checklist