Fixes behaviour for incomplete lines when recover_with_nulls is enabled
#14252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elstehle
added
bug
elstehle
changed the title
recover_with_nulls is enabled
|
/ok to test |
vuule
reviewed
Oct 5, 2023
There was a problem hiding this comment.
could you leave a comment on the changes in logic in the FST (how does this translate into the intended behavior change)? I can glean some logic from the code, but it's possibly made up :D
There was a problem hiding this comment.
I've added comments to the code (get_translation_table and the nl_tokens lambda).
Essentially, we just changed the behaviour when we're in recover_from_error, such that we fail if the JSON line is an incomplete JSON value. E.g.,
- when we see a newline while we are still parsing a
LISTor aSTRUCT, we emit anErrorBegintoken that will mark this incomplete JSON line as invalid. - when we see a newline while we are still parsing a
stringorfield name(e.g.,{"a":"123\n) , we emit anErrorBegintoken that will mark this incomplete JSON line as invalid.
vuule
approved these changes
Oct 6, 2023
|
/ok to test |
elstehle
force-pushed
the
fix/recovering-json-lines-incomplete-lines
branch
from
d087e48 to
bfb5397
Compare
ttnghia
approved these changes
Oct 10, 2023
…ing-json-lines-incomplete-lines
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #14227. Adapts the behaviour of the JSON finite-state transducer (FST) when
recover_with_nullsistrueto be more strict and reject lines that contain incomplete JSON objects (aka records) or JSON arrays (aka lists).Checklist