Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudf::detail::pinned_allocator doesn't throw from deallocate #14251

Merged
merged 3 commits into from
Oct 6, 2023
Merged

cudf::detail::pinned_allocator doesn't throw from deallocate #14251

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c39c688
cudf::detail::pinned_allocator doesn't throw from `deallocate`
robertmaynard Oct 5, 2023
22defa8
correct compile error in debug mode
robertmaynard Oct 5, 2023
5a4e834
Merge branch 'branch-23.12' into bug/remove_throwing_deallocate_pinne…
robertmaynard Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cpp/include/cudf/detail/utilities/pinned_host_vector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,12 @@ class pinned_allocator {
* It is the responsibility of the caller to destroy
* the objects stored at \p p.
*/
__host__ inline void deallocate(pointer p, size_type /*cnt*/) { CUDF_CUDA_TRY(cudaFreeHost(p)); }
__host__ inline void deallocate(pointer p, size_type /*cnt*/)
{
auto dealloc_worked = cudaFreeHost(p);
(void)dealloc_worked;
robertmaynard marked this conversation as resolved.
Show resolved Hide resolved
assert(dealloc_worked == cudaSuccess);
}

/**
* @brief This method returns the maximum size of the \c cnt parameter
Expand Down