Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pytorch related pytest #14198

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Fix pytorch related pytest #14198

merged 2 commits into from
Sep 26, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Calling cudf.Index([]) results in str dtype Index. This PR fixes an issue with a pytorch related pytest by explicitly passing a float64 dtype.

xref: #14116

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Sep 26, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner September 26, 2023 16:53
@galipremsagar galipremsagar self-assigned this Sep 26, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Sep 26, 2023
@rapids-bot rapids-bot bot merged commit a9ec350 into rapidsai:branch-23.10 Sep 26, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @brandon-b-miller