Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parquet reader benchmarks for row selection #14147

Merged
merged 8 commits into from
Sep 25, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Sep 21, 2023

Description

Re-enabled the group of benchmarks that compares row selection options in Parquet reader.
Use read_parquet_metadata to get the column names and number of row groups.
Clean up read chunk computation for ORC and Parquet benchmarks.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule self-assigned this Sep 21, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 21, 2023
@vuule vuule added tests Unit testing for project cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Sep 21, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 21, 2023
@vuule vuule marked this pull request as ready for review September 21, 2023 01:26
@vuule vuule requested a review from a team as a code owner September 21, 2023 01:26
@vuule vuule requested review from harrism and nvdbaranec September 21, 2023 01:26
@vuule vuule added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 25, 2023
@vuule
Copy link
Contributor Author

vuule commented Sep 25, 2023

/merge

@rapids-bot rapids-bot bot merged commit 1b925bf into rapidsai:branch-23.10 Sep 25, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants