-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Add recoverWithNull to JSONOptions and pass to Table.readJSON #14078
Merged
rapids-bot
merged 6 commits into
rapidsai:branch-23.10
from
andygrove:json-options-recovery
Sep 12, 2023
Merged
[Java] Add recoverWithNull to JSONOptions and pass to Table.readJSON #14078
rapids-bot
merged 6 commits into
rapidsai:branch-23.10
from
andygrove:json-options-recovery
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <[email protected]>
andygrove
added
Java
Affects Java cuDF API.
Spark
Functionality that helps Spark RAPIDS
labels
Sep 11, 2023
gerashegalov
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
razajafri
reviewed
Sep 11, 2023
revans2
approved these changes
Sep 12, 2023
revans2
added
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Sep 12, 2023
razajafri
approved these changes
Sep 12, 2023
ttnghia
approved these changes
Sep 12, 2023
/merge |
/ok to test |
Failed style check:
|
pre-commit run clang-format --all-files |
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
Java
Affects Java cuDF API.
non-breaking
Non-breaking change
Spark
Functionality that helps Spark RAPIDS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the recently added
json_reader_options_builder::recovery_mode
option in the JNI layer.closes #14073
Checklist