Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise MixedTypeError when a column of mixed-dtype is being constructed #14050

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Raise MixedTypeError when a column of mixed-dtype is being constructed #14050

merged 2 commits into from
Sep 7, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes #14038

This PR introduces changes that raise an error when a column of object dtype is being constructed when the data is not string or bools.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer breaking Breaking change labels Sep 7, 2023
@galipremsagar galipremsagar self-assigned this Sep 7, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner September 7, 2023 05:29
mroeschke
mroeschke approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs a rebase

@galipremsagar
Copy link
Contributor Author

galipremsagar commented Sep 7, 2023 •
edited
Loading

Just needs a rebase

Will try to merge to save some ci cycles since I don't think we have any conflicting files or PRs merged.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 7, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 6945c4f into rapidsai:branch-23.10 Sep 7, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@bdice bdice Awaiting requested review from bdice

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change bug Something isn't working Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cudf implicitly converting object types to the actual types
2 participants
@galipremsagar @mroeschke