Use cudf::make_empty_column instead of column_view constructor #14030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
vuule
reviewed
Sep 1, 2023
| @@ -47,8 +47,8 @@ TEST_F(StringsColumnTest, Sort) | |||
|
|
|||
| TEST_F(StringsColumnTest, SortZeroSizeStringsColumn) | |||
| { | |||
| cudf::column_view zero_size_strings_column( | |||
| cudf::data_type{cudf::type_id::STRING}, 0, nullptr, nullptr, 0); | |||
| auto const zero_size_strings_column = cudf::make_empty_column(cudf::type_id::STRING)->view(); | |||
There was a problem hiding this comment.
is this safe? we're keeping a view of a column that's a temporary object. The pattern in gather_str_tests.cpp looks more intuitive to me.
There was a problem hiding this comment.
This is indeed safe. The return column_view contains no data. It has member data like type, etc. But the size and other values are set to null/zero. So there is no dependency on the column it came from.
3 tasks
vuule
approved these changes
Sep 1, 2023
hyperbolic2346
approved these changes
Sep 2, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces places where the
cudf::column_view(type,size,...)constructor was used to create an empty view with a call tocudf::make_column_view(type)->view().This helps minimize the dependency on calling the constructors directly as part of the work needed for #13733 which may require an update to the
column_viewclasses and its constructor(s).Most of the changes occur in strings gtests source files.
No functionality or behavior has changed.
Checklist