Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve types of scalar being returned when possible in quantile #14014

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Preserve types of scalar being returned when possible in quantile #14014

merged 4 commits into from
Aug 31, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

closes #14002

This PR changes the behavior of the quantile API by preserving the return type of scalar interpolation is either one of "lower", "higher", "nearest".

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Aug 31, 2023
@galipremsagar galipremsagar self-assigned this Aug 31, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner August 31, 2023 02:08
@galipremsagar galipremsagar requested review from vyasr and isVoid August 31, 2023 02:08
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 31, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 31, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ad9fa50 into rapidsai:branch-23.10 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Allow quantile(0.5) to behave like median and not always return float
3 participants
@galipremsagar @vyasr @bdice