Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose streams in public filling APIs #13990

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Expose streams in public filling APIs #13990

merged 3 commits into from
Aug 29, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Aug 29, 2023

Description

Contributes to #925

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added feature request New feature or request 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 29, 2023
@vyasr vyasr added this to the Enable streams milestone Aug 29, 2023
@vyasr vyasr requested a review from a team as a code owner August 29, 2023 02:57
@vyasr vyasr self-assigned this Aug 29, 2023
@vyasr vyasr requested review from ttnghia and davidwendt August 29, 2023 02:57
@github-actions github-actions bot added the CMake CMake build issue label Aug 29, 2023
bdice
bdice approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One improvement to includes, otherwise LGTM.

cpp/tests/streams/filling_test.cpp Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Aug 29, 2023

/merge

@rapids-bot rapids-bot bot merged commit e2e92c4 into rapidsai:branch-23.10 Aug 29, 2023
@vyasr vyasr deleted the feat/streams_filling branch August 29, 2023 18:47
@GregoryKimball GregoryKimball mentioned this pull request Aug 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@davidwendt davidwendt Awaiting requested review from davidwendt davidwendt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
Enable streams
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @bdice @ttnghia