Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name selection in Index.difference and Index.intersection #13986

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Fix name selection in Index.difference and Index.intersection #13986

merged 6 commits into from
Aug 30, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Aug 28, 2023 •
edited
Loading

Description

closes #13985
This PR fixes issues with Index.difference and Index.intersection API where the name selection was incorrect and NA values handling wasn't happening in these two APIs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added the 2 - In Progress Currently a work in progress label Aug 28, 2023
@galipremsagar galipremsagar self-assigned this Aug 28, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 28, 2023
@galipremsagar galipremsagar added bug Something isn't working 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change and removed 2 - In Progress Currently a work in progress labels Aug 29, 2023
@galipremsagar galipremsagar marked this pull request as ready for review August 29, 2023 16:33
@galipremsagar galipremsagar requested a review from a team as a code owner August 29, 2023 16:33
@galipremsagar galipremsagar changed the title Index difference fixes Fix name selection in Index.difference and Index.intersection Aug 29, 2023
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 29, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@galipremsagar
Copy link
Contributor Author

/ok to test

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Aug 30, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 04085ac into rapidsai:branch-23.10 Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@bdice bdice bdice approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Index.difference not returning correct name for the resulting Index
3 participants
@galipremsagar @bdice @mroeschke