Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CategoricalIndex ordering in Groupby.agg when pandas-compatibility mode is enabled #13978

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix CategoricalIndex ordering in Groupby.agg when pandas-compatibility mode is enabled #13978

merged 1 commit into from
Aug 28, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

closes #13974

This PR re-calculates the CategoricalIndex's categories order to match the order in which the grouping has been done for the CategoricalColumn. This fix is being done only when pandas-compatibility mode is enabled.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 27, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner August 27, 2023 17:55
@galipremsagar galipremsagar requested a review from shwina August 27, 2023 17:55
@galipremsagar galipremsagar self-assigned this Aug 27, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 28, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8a78d68 into rapidsai:branch-23.10 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] grouping on categorical column isn't resulting in re-calculation of categories order
2 participants
@galipremsagar @mroeschke