Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce a fatal error if cudf is unable to find pyarrow include directory #13976

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Produce a fatal error if cudf is unable to find pyarrow include directory #13976

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5348ca8
fatal error if unable to find pyarrow include dir
cwharris Aug 27, 2023
d023565
fix styles
cwharris Aug 28, 2023
8ccc57e
Merge branch 'branch-23.10' of github.com:rapidsai/cudf into pyarrow-…
cwharris Aug 28, 2023
ad515f5
Merge branch 'branch-23.10' into pyarrow-dir-error
cwharris Aug 28, 2023
c4e9d36
Merge branch 'branch-23.10' into pyarrow-dir-error
cwharris Aug 31, 2023
42d5ecb
Merge branch 'branch-23.10' into pyarrow-dir-error
vyasr Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions python/cudf/cudf/_lib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,15 @@ find_package(Python 3.9 REQUIRED COMPONENTS Interpreter)
execute_process(
COMMAND "${Python_EXECUTABLE}" -c "import pyarrow; print(pyarrow.get_include())"
OUTPUT_VARIABLE PYARROW_INCLUDE_DIR
ERROR_VARIABLE PYARROW_ERROR
RESULT_VARIABLE PYARROW_RESULT
OUTPUT_STRIP_TRAILING_WHITESPACE
)

if(${PYARROW_RESULT})
message(FATAL_ERROR "Error while trying to obtain pyarrow include directory:\n${PYARROW_ERROR}")
endif()

set(targets_using_arrow_headers interop avro csv orc json parquet)
foreach(target IN LISTS targets_using_arrow_headers)
target_include_directories(${target} PRIVATE "${PYARROW_INCLUDE_DIR}")
Expand Down