Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HostMemoryAllocator in jni::allocate_host_buffer #13975

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Use HostMemoryAllocator in jni::allocate_host_buffer #13975

merged 1 commit into from
Aug 30, 2023

Conversation

gerashegalov
Copy link
Contributor

@gerashegalov gerashegalov commented Aug 26, 2023 •
edited
Loading

Description

Fixes #13940
Contributes to NVIDIA/spark-rapids#8889

  • Pass an explicit host memory allocator to jni::allocate_host_buffer
  • Consistently check for errors from NewGlobalRef
  • Consistently guard against DelteteGlobalRef on a null

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@gerashegalov gerashegalov added Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Aug 26, 2023
@gerashegalov gerashegalov requested a review from a team as a code owner August 26, 2023 19:50
@gerashegalov gerashegalov self-assigned this Aug 26, 2023
gerashegalov added a commit to gerashegalov/spark-rapids-jni that referenced this pull request Aug 26, 2023
@gerashegalov
Use HostMemoryAllocator in ParquetFooter
66d43d7 
depends on rapidsai/cudf#13975

Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov mentioned this pull request Aug 26, 2023
Merged
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 29, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@gerashegalov gerashegalov force-pushed the gerashegalov/issue13940 branch 2 times, most recently from d44161d to a761260 Compare August 29, 2023 23:32
@gerashegalov gerashegalov marked this pull request as draft August 29, 2023 23:36
@gerashegalov gerashegalov changed the title Use HostMemoryAllocator in jni::allocate_host_buffer [WIP] Use HostMemoryAllocator in jni::allocate_host_buffer Aug 29, 2023
@gerashegalov
Use HostMemoryAllocator in jni::allocate_host_buffer
8e97f15 
Fixes rapidsai#13940

Contributes to NVIDIA/spark-rapids#8889

- Pass an explicit host memory allocator to  `jni::allocate_host_buffer`
- Consistently check for errors from NewGlobalRef
- Consistently guard against DelteteGlobalRef on a null

Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov force-pushed the gerashegalov/issue13940 branch from a761260 to 8e97f15 Compare August 30, 2023 00:04
@gerashegalov gerashegalov marked this pull request as ready for review August 30, 2023 00:05
@gerashegalov gerashegalov changed the title [WIP] Use HostMemoryAllocator in jni::allocate_host_buffer Use HostMemoryAllocator in jni::allocate_host_buffer Aug 30, 2023
@gerashegalov
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7b9f4a1 into rapidsai:branch-23.10 Aug 30, 2023
@gerashegalov gerashegalov deleted the gerashegalov/issue13940 branch August 30, 2023 03:59
jlowe pushed a commit to NVIDIA/spark-rapids-jni that referenced this pull request Aug 30, 2023
@gerashegalov
Use HostMemoryAllocator in ParquetFooter (#1377)
c38bc8e 
* Use HostMemoryAllocator in ParquetFooter

depends on rapidsai/cudf#13975

Signed-off-by: Gera Shegalov <[email protected]>

* Fix build

Signed-off-by: Gera Shegalov <[email protected]>

---------

Signed-off-by: Gera Shegalov <[email protected]>
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 Awaiting requested review from revans2

@mythrocks mythrocks Awaiting requested review from mythrocks

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec

Assignees

@gerashegalov gerashegalov

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JNI call path allocate_host_buffer must use HostMemoryAllocator
4 participants
@gerashegalov @jlowe @nvdbaranec @vyasr