Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use thread_index_type in partitioning.cu #13973

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Use thread_index_type in partitioning.cu #13973

merged 1 commit into from
Aug 27, 2023

Conversation

divyegala
Copy link
Member

Description

This PR uses cudf::thread_index_type to avoid overflows.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@divyegala divyegala added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 26, 2023
@divyegala divyegala self-assigned this Aug 26, 2023
@divyegala divyegala requested a review from a team as a code owner August 26, 2023 00:57
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 26, 2023
@divyegala
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 2c7f02c into rapidsai:branch-23.10 Aug 27, 2023
@GregoryKimball GregoryKimball mentioned this pull request Aug 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@divyegala divyegala

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyegala @bdice @karthikeyann