Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use thread_index_type to avoid out of bounds accesses in conditional joins #13971

Merged
merged 9 commits into from
Sep 7, 2023
Merged

Use thread_index_type to avoid out of bounds accesses in conditional joins #13971

merged 9 commits into from
Sep 7, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Aug 25, 2023

Description

See #10368 (and more recently #13771

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 25, 2023
@vyasr vyasr requested a review from a team as a code owner August 25, 2023 22:54
@vyasr vyasr self-assigned this Aug 25, 2023
bdice
bdice reviewed Aug 25, 2023
View reviewed changes
cpp/src/join/conditional_join_kernels.cuh Outdated Show resolved Hide resolved
cpp/src/join/conditional_join_kernels.cuh Show resolved Hide resolved
cpp/src/join/conditional_join_kernels.cuh Outdated Show resolved Hide resolved
@vyasr vyasr requested review from bdice and davidwendt August 28, 2023 16:58
@GregoryKimball GregoryKimball mentioned this pull request Aug 28, 2023
Open
@vyasr vyasr requested review from davidwendt and bdice September 5, 2023 16:50
bdice
bdice approved these changes Sep 7, 2023
View reviewed changes
cpp/src/join/conditional_join_kernels.cuh Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Sep 7, 2023

/merge

@rapids-bot rapids-bot bot merged commit b4da39c into rapidsai:branch-23.10 Sep 7, 2023
@vyasr vyasr deleted the fix/thread_index_joins branch March 31, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @bdice @PointKernel @davidwendt