Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cudf::thread_index_type in strings custom kernels #13968

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Use cudf::thread_index_type in strings custom kernels #13968

merged 3 commits into from
Aug 28, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Adds cudf::thread_index_type usage when calculating the thread index in custom kernels in src/strings/attributes.cu and src/strings/convert/convert_urls.cu

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 25, 2023
@davidwendt davidwendt self-assigned this Aug 25, 2023
@davidwendt davidwendt requested a review from a team as a code owner August 25, 2023 18:40
@davidwendt davidwendt requested review from ttnghia and vuule August 25, 2023 18:40
@davidwendt davidwendt requested a review from vuule August 25, 2023 20:35
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3c8ce98 into rapidsai:branch-23.10 Aug 28, 2023
@davidwendt davidwendt deleted the thread-idx-strings branch August 28, 2023 16:53
@GregoryKimball GregoryKimball mentioned this pull request Aug 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @ttnghia @vuule