Added pinned pool reservation API for java #13964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
added
3 - Ready for Review
gerashegalov
approved these changes
Aug 25, 2023
| if (section.size >= bytes && section.size <= alignedSize) { | ||
| allocated = section; | ||
| section = null; | ||
| // Not need for reserveAllocInternal because the original section is already tracked |
There was a problem hiding this comment.
Suggested change
| // Not need for reserveAllocInternal because the original section is already tracked | |
| // No need for reserveAllocInternal because the original section is already tracked |
| @Override | ||
| public synchronized HostMemoryBuffer allocate(long bytes) { | ||
| if (section == null || section.size < bytes) { | ||
| throw new OutOfMemoryError("Reservation didn't have enough space for " + bytes); |
There was a problem hiding this comment.
would it be helpful for diagnostics to include the section=null / section.size in the exception message?
|
/merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds in an API to java to reserve pinned memory. It is very much like allocating it, but provides a way to guarantee up front that there is enough memory for multiple allocations to succeed.
Checklist