Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cudf::thread_index_type in get_json_object and tdigest kernels #13962

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Use cudf::thread_index_type in get_json_object and tdigest kernels #13962

merged 5 commits into from
Aug 29, 2023

Conversation

nvdbaranec
Copy link
Contributor

Convert the grid-stride loop in get_json_object_kernel to use cudf::thread_index_type. Convert compute_percentiles_kernel to use cudf::thread_index_type.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@nvdbaranec nvdbaranec added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 25, 2023
@nvdbaranec nvdbaranec requested a review from a team as a code owner August 25, 2023 15:56
mythrocks
mythrocks approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good to incorporate the global_thread_id() change.

@GregoryKimball GregoryKimball mentioned this pull request Aug 28, 2023
Open
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 29, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@davidwendt
Copy link
Contributor

Looks like someone did not set up their github account to support signed commits.

@davidwendt
Copy link
Contributor

/ok to test

@nvdbaranec
Copy link
Contributor Author

/merge

@ajschmidt8
Copy link
Member

ajschmidt8 commented Aug 29, 2023 •
edited
Loading

admin merging due to the /merge comment and since the last commit was empty, but the commit before that passed CI.

@ajschmidt8 ajschmidt8 merged commit 1452200 into rapidsai:branch-23.10 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt left review comments

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@mythrocks mythrocks mythrocks approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nvdbaranec @davidwendt @ajschmidt8 @hyperbolic2346 @bdice @mythrocks @karthikeyann