Fix an issue with IntervalIndex.repr when null values are present
#13958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
changed the title
IntervalIndex.repr when there are null valuesIntervalIndex.repr when null values are present
galipremsagar
added
bug
mroeschke
reviewed
Aug 25, 2023
| return f"interval[{self.subtype}, {self.closed}]" | ||
|
|
||
| def __str__(self) -> str: |
There was a problem hiding this comment.
Just noting that pandas' IntervalDtype.__str__ considers a few more cases, but I am not sure if cudf has all these cases implemented
There was a problem hiding this comment.
In case of cudf, looks like subtype is mandatory and optional for pandas.
mroeschke
approved these changes
Aug 25, 2023
galipremsagar
added
5 - Ready to Merge
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #13954
This PR fixes an issue with
IntervalIndex.repr, where there was a silent failure because of no dedicated_clean_nulls_from_indexand theGenericIndex._clean_nulls_from_indexwouldn't work because a type-cast tostrisn't implemented.Checklist