Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type metadata issue preservation with Column.unique #13957

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Fix type metadata issue preservation with Column.unique #13957

merged 2 commits into from
Aug 25, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

closes #13953

This PR fixes an issue with Column.unique where the type-metadata wasn't being preserved in the end before returning the unique values. This lead to IntervalColumn being returned as a StructColumn.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Aug 25, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner August 25, 2023 00:45
@galipremsagar galipremsagar self-assigned this Aug 25, 2023
brandon-b-miller
brandon-b-miller approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 25, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5d5f4f5 into rapidsai:branch-23.10 Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] IntervalIndex.unique is resulting in an incomplete due to lack of post-processing
2 participants
@galipremsagar @brandon-b-miller