Handle as_index in GroupBy.apply
#13951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
bug
Comment on lines
+1440
to
+1441
| result = result.reset_index() | ||
| result[None] = result.pop(0) |
There was a problem hiding this comment.
Suggested change
| result = result.reset_index() | |
| result[None] = result.pop(0) | |
| result = result.reset_index(drop=True) |
Could we do this instead?
There was a problem hiding this comment.
When I try that, I get a Series still. We're trying to end up with a DataFrame with a column named None:
0 1.0
1 2.5
dtype: float64
vs
y None
0 0 1.0
1 1 2.5
There was a problem hiding this comment.
I see, got it 👍 Then this change LGTM
galipremsagar
approved these changes
Aug 25, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13897