Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index of Groupby.apply results when it is performed on empty objects #13944

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Fix index of Groupby.apply results when it is performed on empty objects #13944

merged 6 commits into from
Aug 23, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

closes #13939
This PR fixes two issues with Groupby.apply, where the index of the result was not being set correctly and there is a corner case for bool dtype that has to be handled for sum & product operations.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Aug 23, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner August 23, 2023 19:53
@galipremsagar galipremsagar self-assigned this Aug 23, 2023
bdice
bdice approved these changes Aug 23, 2023
View reviewed changes
python/cudf/cudf/core/groupby/groupby.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 23, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 171fc91 into rapidsai:branch-23.10 Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Index of empty objects not set in Groupby.apply
2 participants
@galipremsagar @bdice