Fix integer overflow in shim device_sum functions
#13943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
bug
bdice
reviewed
Aug 23, 2023
python/cudf/udf_cpp/shim.cu
Outdated
| int64_t size, | ||
| T* sum) | ||
| template <typename T, std::enable_if_t<std::is_integral_v<T>, int> = 0> | ||
| __device__ int64_t device_sum(cooperative_groups::thread_block const& block, |
There was a problem hiding this comment.
Rather than writing an entirely new SFINAE overload, could we have a single kernel and write something like this in a second template parameter:
typename AccumT = std::conditional<std::is_integral_v<T>, int64_t, T>
There was a problem hiding this comment.
yes! was hoping someone would comment with something like this :)
There was a problem hiding this comment.
Should be updated! Looking much cleaner now, thanks.
|
I think this makes sense. Of course, there are many ways to still get a bad result, but pandas also gets a bad result in those cases. Overflowing int64 is the natural one, but pandas hilariously converts a sum of |
bdice
approved these changes
Aug 25, 2023
Co-authored-by: Bradley Dice <[email protected]>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13873