Fix type mismatch in groupby reduction for empty objects #13942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
bdice
reviewed
Aug 23, 2023
| @@ -563,7 +569,10 @@ def agg(self, func): | |||
| ): | |||
| # Structs lose their labels which we reconstruct here | |||
| col = col._with_type_metadata(cudf.ListDtype(orig_dtype)) | |||
| data[key] = col | |||
| if is_empty and is_reduction and len(col) == 0: | |||
There was a problem hiding this comment.
If the values of is_empty and is_reduction are only used here, maybe we can declare/evaluate them closer to here?
There was a problem hiding this comment.
Yupp, moved it closer.
bdice
approved these changes
Aug 23, 2023
galipremsagar
added
5 - Ready to Merge
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #13941
This PR preserves the column types, for group by reduction operations that are performed on empty objects.
Checklist