Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed processed bytes calculation in APPLY_BOOLEAN_MASK benchmark. #13937

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

Blonck
Copy link
Contributor

@Blonck Blonck commented Aug 23, 2023

Due to missing parentheses in APPLY_BOOLEAN_MASK benchmark, the number of written bytes were not multiplied by the number of iterations of this benchmark.

This patch relates to #13735.

Checklist

Due to missing parentheses in APPLY_BOOLEAN_MASK benchmark the number
of written bytes were not multiplied by the number of iterations
of this benchmark.

This patch relates to rapidsai#13735.
@rapids-bot
Copy link

rapids-bot bot commented Aug 23, 2023

Pull requests from external contributors require approval from a rapidsai organization member with write permissions or greater before CI can begin.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 23, 2023
@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress non-breaking Non-breaking change labels Aug 23, 2023
@davidwendt
Copy link
Contributor

/ok to test

@Blonck Blonck marked this pull request as ready for review August 23, 2023 13:43
@Blonck Blonck requested a review from a team as a code owner August 23, 2023 13:43
@Blonck Blonck requested review from ttnghia and vuule August 23, 2023 13:43
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 23, 2023
@davidwendt
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit e16ed81 into rapidsai:branch-23.10 Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants