Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with loc when column names is MultiIndex #13929

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Fix an issue with loc when column names is MultiIndex #13929

merged 7 commits into from
Aug 22, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #13864

This PR fixes an issue with loc indexer where some special handling needs to be done when columns is of type MultiIndex.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Aug 21, 2023
@galipremsagar galipremsagar self-assigned this Aug 21, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner August 21, 2023 18:25
wence-
wence- requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, but some minor logic cleanup in the column name generation is needed.

python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_indexing.py Show resolved Hide resolved
python/cudf/cudf/core/column_accessor.py Show resolved Hide resolved
@galipremsagar galipremsagar requested review from wence- and bdice August 22, 2023 16:07
wence-
wence- approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @galipremsagar

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 22, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 62148b4 into rapidsai:branch-23.10 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@bdice bdice Awaiting requested review from bdice

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] LocIndexer of a DataFrame with a MultiIndex columns with a single label tuple returns DataFrame
3 participants
@galipremsagar @wence- @bdice