Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of typecasting in searchsorted #13925

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Fix handling of typecasting in searchsorted #13925

merged 6 commits into from
Aug 22, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #13902

This PR fixes a type-casting issue with searchsorted where typecast was done to the values dtype instead of inspecting both input and values columns and converting them to common dtypes.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Aug 19, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner August 19, 2023 17:31
@galipremsagar galipremsagar self-assigned this Aug 19, 2023
wence-
wence- approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion for a test, but looks good.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 22, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0e5f9db into rapidsai:branch-23.10 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] LocIndexing a float index with integer slice does not respect end point
3 participants
@galipremsagar @wence- @mroeschke