-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add java API to get size of host memory needed to copy column view #13919
Conversation
Co-authored-by: Jim Brennan <[email protected]>
@gerashegalov and @ttnghia sorry to change the code on you. I realized that we already had some C++ code to do almost the exact same thing, so I switched over to use it instead. Just to remove duplication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just optional nits
Great catch @razajafri I updated the code to follow the alignment that C++ says it should be. Turns out, at least for my desktop, it is 32-byte aligned. So 64-bytes was not too far off for what we really wanted. |
build |
/merge |
Description
To help with work for host memory management in java this provides an API to know how much memory is needed on the host to copy the data before it happens.
This was written by @jbrennan333 but I am taking over the patch to get it in.
Checklist