Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cudf::size_type instead of int32 where appropriate in nvtext functions #13915

Merged
merged 9 commits into from
Aug 25, 2023
Merged

Use cudf::size_type instead of int32 where appropriate in nvtext functions #13915

merged 9 commits into from
Aug 25, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Aug 18, 2023 •
edited
Loading

Description

Updates code to use size_type instead of int32_t where appropriate (i.e. offsets).
Also changes some code logic for resolving a thread-index in a custom kernel to use the cudf::thread_index_type to help avoid overflow of 32-bit integer types.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 18, 2023
@davidwendt davidwendt self-assigned this Aug 18, 2023
@davidwendt davidwendt changed the title Use cudf::thread_index_type in nvtext functions Use cudf::size_type instead of int32 where appropriate in nvtext functions Aug 18, 2023
@davidwendt davidwendt changed the title Use cudf::size_type instead of int32 where appropriate in nvtext functions Use cudf::size_type instead of int32 where appropriate in nvtext functions Aug 21, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 21, 2023
@davidwendt davidwendt marked this pull request as ready for review August 21, 2023 15:07
@davidwendt davidwendt requested a review from a team as a code owner August 21, 2023 15:07
@davidwendt davidwendt requested review from vyasr and bdice August 21, 2023 15:07
bdice
bdice approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, just one small comment.

cpp/src/text/subword/wordpiece_tokenizer.cu Show resolved Hide resolved
@davidwendt davidwendt changed the title Use cudf::size_type instead of int32 where appropriate in nvtext functions Use cudf::size_type instead of int32 where appropriate in nvtext functions Aug 24, 2023
@davidwendt davidwendt changed the title Use cudf::size_type instead of int32 where appropriate in nvtext functions Use cudf::size_type instead of int32 where appropriate in nvtext functions Aug 25, 2023
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4591dd3 into rapidsai:branch-23.10 Aug 25, 2023
@davidwendt davidwendt deleted the nvtext-int32-size-type branch August 25, 2023 18:18
@GregoryKimball GregoryKimball mentioned this pull request Aug 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @karthikeyann