Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use empty() instead of size() where possible #13908

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Use empty() instead of size() where possible #13908

merged 2 commits into from
Aug 18, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Aug 17, 2023

Description

Adds empty() to hostdevice_vector.
Check empty() instead of checking the column/buffer/vector size().

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added cuIO cuIO issue tech debt non-breaking Non-breaking change labels Aug 17, 2023
@vuule vuule self-assigned this Aug 17, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 17, 2023
@vuule vuule added code quality improvement Improvement / enhancement to an existing function labels Aug 17, 2023
@vuule vuule marked this pull request as ready for review August 18, 2023 00:15
@vuule vuule requested a review from a team as a code owner August 18, 2023 00:15
karthikeyann
karthikeyann approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vuule
Copy link
Contributor Author

vuule commented Aug 18, 2023

/merge

@rapids-bot rapids-bot bot merged commit f233422 into rapidsai:branch-23.10 Aug 18, 2023
@vuule vuule deleted the cuio-use-empty branch August 18, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @karthikeyann @davidwendt