Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cudf::thread_index_type in concatenate.cu. #13906

Merged
merged 5 commits into from
Sep 2, 2023
Merged

Use cudf::thread_index_type in concatenate.cu. #13906

merged 5 commits into from
Sep 2, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 17, 2023 •
edited
Loading

Description

This PR uses cudf::thread_index_type in concatenate.cu to avoid risk of overflow.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner August 17, 2023 20:45
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 17, 2023
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Aug 17, 2023
@bdice bdice self-assigned this Aug 17, 2023
@GregoryKimball GregoryKimball mentioned this pull request Aug 21, 2023
Open
@bdice bdice requested a review from ttnghia September 1, 2023 21:29
@bdice
Copy link
Contributor Author

bdice commented Sep 1, 2023

/merge

@rapids-bot rapids-bot bot merged commit bbbb143 into rapidsai:branch-23.10 Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@divyegala divyegala divyegala approved these changes

@PointKernel PointKernel PointKernel approved these changes

@ttnghia ttnghia ttnghia approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@bdice bdice

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdice @ttnghia @PointKernel @divyegala @vuule