Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cuda-nvtx-dev CUDA 12 package. #13901

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 17, 2023

Description

Fixes the CUDA 12 cuda-nvtx-dev package name. This issue was found by @davidwendt and I verified that this fixes it.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner August 17, 2023 18:08
@vuule vuule added bug Something isn't working non-breaking Non-breaking change labels Aug 17, 2023
@bdice bdice self-assigned this Aug 17, 2023
@jakirkham
Copy link
Member

Thanks Bradley! 🙏

Do we need to rerun rapids-dependency-file-generator?

@github-actions github-actions bot added the conda label Aug 17, 2023
@bdice
Copy link
Contributor Author

bdice commented Aug 17, 2023

@jakirkham Good catch. There were no changes being rendered to the environment, which was not what I expected. I found and fixed several issues with the placement of cuda-nvtx in the dependency lists in commit d5005db. We should've known this was a problem before because we had a workaround specific to cudf's Java builds, which is now corrected for all builds.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 42cab26 into rapidsai:branch-23.10 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants