Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory access error in cudf::shift for sliced strings #13894

Merged
merged 11 commits into from
Aug 23, 2023
Merged

Fix memory access error in cudf::shift for sliced strings #13894

merged 11 commits into from
Aug 23, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Fixes cudf::strings::detail::shift logic with sliced input strings column when copying the chars data to the output column.
Added additional tests including a null fill scalar.

Closes #13852

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Aug 16, 2023
@davidwendt davidwendt self-assigned this Aug 16, 2023
@davidwendt davidwendt changed the title Bug sliced strings shift Fix memory access error in cudf::shift for sliced strings Aug 16, 2023
@davidwendt davidwendt changed the title Fix memory access error in cudf::shift for sliced strings Fix memory access error in cudf::shift for sliced strings Aug 16, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 17, 2023
@davidwendt davidwendt marked this pull request as ready for review August 18, 2023 00:00
@davidwendt davidwendt requested a review from a team as a code owner August 18, 2023 00:00
@davidwendt davidwendt requested review from vyasr and bdice August 18, 2023 00:00
@davidwendt davidwendt changed the title Fix memory access error in cudf::shift for sliced strings Fix memory access error in cudf::shift for sliced strings Aug 18, 2023
@davidwendt davidwendt changed the title Fix memory access error in cudf::shift for sliced strings Fix memory access error in cudf::shift for sliced strings Aug 21, 2023
bdice
bdice approved these changes Aug 22, 2023
View reviewed changes
cpp/src/strings/copying/shift.cu Outdated Show resolved Hide resolved
PointKernel
PointKernel approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 88a8efc into rapidsai:branch-23.10 Aug 23, 2023
@davidwendt davidwendt deleted the bug-sliced-strings-shift branch August 23, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Failing groupby-apply on string column can leave dataframe in unusable state
3 participants
@davidwendt @bdice @PointKernel