Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable creation of DatetimeIndex when freq is passed to cudf.date_range #13890

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Disable creation of DatetimeIndex when freq is passed to cudf.date_range #13890

merged 3 commits into from
Aug 16, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

In #13857, we disabled the construction of DatetimeIndex & TimedeltaIndex when their pandas counter-parts have freq set. However, when freq is passed to date_range, the expectation and pandas-behavior is to return a DateTimeIndex with freq set. This isn't possible with cudf currently, hence disabled the construction of DatetimeIndex in this case.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 16, 2023
@galipremsagar galipremsagar self-assigned this Aug 16, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner August 16, 2023 16:50
bdice
bdice approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Also, I see that Timestamp.freq was removed in pandas 2 (probably because it's meaningless as far as I can tell). That doesn't really help with the DatetimeIndex but might help with the timestamps themselves.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 16, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fdeabab into rapidsai:branch-23.10 Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @bdice