Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return nan when one variable to be correlated has zero variance in JIT GroupBy Apply #13884

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Return nan when one variable to be correlated has zero variance in JIT GroupBy Apply #13884

merged 3 commits into from
Aug 21, 2023

Conversation

brandon-b-miller
Copy link
Contributor

Closes #13875

@brandon-b-miller brandon-b-miller requested a review from a team as a code owner August 15, 2023 16:51
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 15, 2023
@brandon-b-miller
Copy link
Contributor Author

This was found during #13813

@brandon-b-miller brandon-b-miller added bug Something isn't working numba Numba issue non-breaking Non-breaking change labels Aug 15, 2023
vyasr
vyasr approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming that a new test is added as per Prem's request.

@galipremsagar
Copy link
Contributor

/merge

1 similar comment
@brandon-b-miller
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5eee8ac into rapidsai:branch-23.10 Aug 21, 2023
@brandon-b-miller
Copy link
Contributor Author

@galipremsagar jinx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change numba Numba issue Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] JIT GroupBy.apply corr() aggregation wrong results when one variable has zero variance
3 participants
@brandon-b-miller @galipremsagar @vyasr