Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for the presence of all values in MultiIndex.isin #13879

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Check for the presence of all values in MultiIndex.isin #13879

merged 1 commit into from
Aug 14, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #13861

This PR fixes an issue in MulitIndex.isin where, previously we calculated partial matches. With this PR we will only return True for complete matches.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Aug 14, 2023
@galipremsagar galipremsagar self-assigned this Aug 14, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner August 14, 2023 21:39
bdice
bdice approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this covers the case in that bug. I tried to think if there was a cheaper/faster way than to call merge, but I didn't immediately see anything.

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8b72662 into rapidsai:branch-23.10 Aug 14, 2023
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] MultiIndex.isin returns True instead of False for partial element matching tuples
3 participants
@galipremsagar @bdice @vyasr